This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
OPID Monitoring BugFixes #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue when opids may have been cleared from node but not pool. Do not increase opid count when `executing` as another app may have created an operation.
Treat address longer than 40 chars as invalid Treat address shorter than 30 chars as invalid
|
This needs more testing for the added invalid address handling in payment processor. |
|
@hellcatz how will this work with pplnt? will the shares end up being removed since that address didn't actually mine the round? |
|
Yes, the shares will be "reduced" but still given to the "invalidAddress" in config during paymentProcessing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue when opids may have been cleared from node but not pool.
Do not increase opid count when
executingas another app may have created an operation.