This repository has been archived by the owner on Nov 27, 2020. It is now read-only.
App v2 #11
Merged
App v2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converts deps stored using probot-metadata to the new syntax
probot-metadata only fetchs issue's body if it's not passed as a second param e.g:
metadata(context, {..., body: 'text'})
Since we already know the body before and after migration, we can save 2 HTTP calls by passing the issue body.
ryanhiebert
approved these changes
Feb 6, 2018
|
|
||
| [ref]: https://git.io/vNxHZ | ||
| [repo]: https://github.com/ahmed-taj/dep | ||
| [issues]: https://github.com/ahmed-taj/dep/issues |
|
This PR will be merged into the master branch (=> immediate deploy) on 15 Feb if no issues found. Thanks! |
This was referenced Feb 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
/dependsand/ensurecommands in favor of the new single inline command:depend(no slash). The new command works similar to how you may close issues using keywords on GitHub but only in pull request description.The following keywords followed by an issue number will mark that issue as a dependency:
Why new syntax?
Why not support both? because I think things will get messy really soon, and the source would be harder to maintain!
Examples
You may write the end of PR description:
or it can be anywhere:
All dependencies added using the old commands should be converted automatically (hopefully) to the new syntax. The old commands will just write a deprecation notice.
/CC for review and comments @nesl247, @ryanhiebert @lo1tuma, and @JasonEtco ;)
Resolves #3 and resolves #8