Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do a better job with movie lookups if year is part of the query #37

Closed
jrwren opened this issue Oct 16, 2020 · 1 comment
Closed

do a better job with movie lookups if year is part of the query #37

jrwren opened this issue Oct 16, 2020 · 1 comment
Assignees

Comments

@jrwren
Copy link
Contributor

jrwren commented Oct 16, 2020

!movie return multiple results when it queries the service? could i send you a patch that detects 19\d\d or 20\d\d in the query and filters the results by year?
@jrwren
Copy link
Contributor Author

jrwren commented Oct 17, 2020

I guess the trakt api already does this.

Searching for The Karate Kid gives a huge result, but searching for The Karate Kid 1984 gives this result:

[
{
type: 'movie',
score: 28.85471,
movie: { title: 'The Karate Kid', year: 1984, ids: [Object] }
},
{
type: 'movie',
score: -3.4028235e+38,
movie: { title: 'The Way of the Karate Kid', year: null, ids: [Object] }
}
]

so... Closing without a patch.

@jrwren jrwren closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant