Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for redundant logging + Feature adds #12

Merged
merged 2 commits into from
May 12, 2021
Merged

Fix for redundant logging + Feature adds #12

merged 2 commits into from
May 12, 2021

Conversation

z7r1k3
Copy link
Owner

@z7r1k3 z7r1k3 commented May 11, 2021

Fixes #4

Squashed commit of the following:
commit 25d5e2e
Author: z7r1k3 32229444+z7r1k3@users.noreply.github.com
Date: Tue May 11 12:14:33 2021 -0600

Fixed logging from previous commit

Introduced get_prefix() caching

Set unique mode as default

commit c7b1a04
Author: z7r1k3 32229444+z7r1k3@users.noreply.github.com
Date: Fri May 7 23:01:07 2021 -0600

Fix for redundant logging; Added unique logging

commit 25d5e2e
Author: z7r1k3 <32229444+z7r1k3@users.noreply.github.com>
Date:   Tue May 11 12:14:33 2021 -0600

    Fixed logging from previous commit

    Introduced get_prefix() caching

    Set unique mode as default

commit c7b1a04
Author: z7r1k3 <32229444+z7r1k3@users.noreply.github.com>
Date:   Fri May 7 23:01:07 2021 -0600

    Fix for redundant logging; Added unique logging
@z7r1k3
Copy link
Owner Author

z7r1k3 commented May 11, 2021

Upon further review, it looks like combining unique mode with standard output gives a confusing and inconsistent result in the terminal. This is due to standard output relying on depth, but unique mode not displaying depth. This will be fixed prior to merging.

@z7r1k3 z7r1k3 marked this pull request as draft May 11, 2021 19:05
Added default options

Improved invalid input handling

Set urlopen timeout to 20 seconds

Refactored variables
@z7r1k3 z7r1k3 marked this pull request as ready for review May 12, 2021 00:53
@z7r1k3
Copy link
Owner Author

z7r1k3 commented May 12, 2021

Reviewed, tested, and self-approved.

@z7r1k3 z7r1k3 merged commit a511523 into master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundantly Logged URLs Show Conflicting Information
1 participant