Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotation on bedaura #27

Closed
wants to merge 1 commit into from
Closed

Conversation

ProfKambing
Copy link
Contributor

i tried to add the setrotationyaw but its kinda retarded

@Morten-Renner Morten-Renner self-requested a review July 22, 2021 15:14
@Morten-Renner
Copy link
Collaborator

I haven't tested it yet. But it seems fine so far.


A potential issue might be the following.
Sending an additional packet could lead to an AC kick/ban due to packet spam. For some ACs we're already very close to the maximum.

Or it cloud interfere when a player hits an entity at the same time. For the server it would look like the player is looking at the bed and hitting an entity at a different direction. In my experience more ACs react to this than breaking a bed without looking at it.

Sending the PlayerLook packet should at least be optional. A Setting for it would be good.

@Morten-Renner Morten-Renner added the enhancement New feature or request label Jul 22, 2021
@Morten-Renner Morten-Renner linked an issue Jul 22, 2021 that may be closed by this pull request
@Morten-Renner
Copy link
Collaborator

Also please make sure next time that you commit with the default line seperators. We use CRLF the Windows default. Thats why git shows that every line changed.

Copy link
Collaborator

@Morten-Renner Morten-Renner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add a Setting for this feature, make it optional.
  2. Please commit the file with CRLF line breaks.

@ProfKambing
Copy link
Contributor Author

okay

@ProfKambing
Copy link
Contributor Author

i could make it use yawrotation instead of packet

@zPeanut zPeanut mentioned this pull request Jul 26, 2021
@zPeanut
Copy link
Owner

zPeanut commented Jul 27, 2021

make it toggable and ill merge

@zPeanut
Copy link
Owner

zPeanut commented Jul 27, 2021

also use yawrotation

@ProfKambing
Copy link
Contributor Author

okay

@ProfKambing ProfKambing closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rotate mode on bedaura
3 participants