feat: Add support for new 'x-kick-auth' header. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zSoulweaver
reviewed
Jan 27, 2024
There was a problem hiding this comment.
Looks good to me. I don't have this issue on my system at all, so I haven't encountered it. thankfully for me. I'm happy to put this little workaround in until the public API is available for those having issues however.
I assume this header value is manually captured via a browser?
In terms of the PR itself, just a few small nitpicky things.
- I think renaming
kickAuthtokickAuthHeaderis a bit more obvious to what that parameter is for, what do you think? - I've left a comment regarding my other nitpick in regards to the function parameter. I do agree with you in not adding it to the
LoginCredentialsinterface.
|
Resolved! |
|
LGTM. Sorry for delay, I'll go ahead and publish a new version shortly. Edit: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add an optional
x-kick-authheader to eachcallKickApi()call.In my case, this resolves the issue of being unable to use the
kick-token-providerendpoint when usingclient.api.authentication.login(). This was due to a CloudFlare challenge before the response of the endpoint.This header was verified using
curlwith and without the header on the machine receiving the CloudFlare challenge.I wasn't sure if I should have added the auth token as an optional field inside of the
LoginCredentialsinterface or as an extrakickAuthparameter when callinglogin(), so I chose the latter.