Deep copy mock data to avoid cross-test pollution #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may not be the cleanest approach, but it fixes the test for me. |
|
Thanks for putting this together. However, the ci test is failing now. Any thoughts on the cause? |
Mock data was previously static dictionaries shared across all TeslaMock instances, so accidental dependencies were introduced between the tests. Now each mock instance has its own deep copy.
graham33
force-pushed
the
fix/test_isolation
branch
from
74c3a4f
to
02e9b67
Compare
|
I wasn't running the asyncio tests in my environment, so didn't see that the data in TeslaMock needs to by shared for the lifetime of the test (mine returned a new deep copy on every function call). I've rewritten it and the tests now pass, but it's a more invasive change that could be done a few different ways. I've tried to keep the change minimal vs a big refactoring. |
Closed
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121