Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved problem with import of int_sockopts which were moved from core to sugar #7

Merged
merged 2 commits into from
Jun 18, 2014

Conversation

vlcinsky
Copy link
Collaborator

With pyzmq 13.*, int_socopts were moved from zmq.core.constants to zmq.sugar

This caused failure to run if the system contained newer version of pyzmq.

… to zmq.sugar

setup.py got removed unused import

        modified:   lib/zmqc.py
        modified:   setup.py
@owend
Copy link

owend commented Jul 30, 2013

Bump? Seems like zmqc is pretty much useless without this... To be more clear, with a fresh install on ubuntu, I get this error:

$ zmqc -rc SUB 'tcp://localhost:5555'
Traceback (most recent call last):
File "/usr/local/bin/zmqc", line 9, in
load_entry_point('zmqc==0.1.0', 'console_scripts', 'zmqc')()
File "/usr/local/lib/python2.7/dist-packages/zmqc.py", line 286, in main
sock_opts = get_sockopts(args.sock_opts)
File "/usr/local/lib/python2.7/dist-packages/zmqc.py", line 227, in get_sockopts
int: set(zmq.core.constants.int_sockopts).union(
AttributeError: 'module' object has no attribute 'int_sockopts'

@vlcinsky
Copy link
Collaborator Author

Exactly. I found zmqc very valuable tool, allowing me to pass realtime various kind of messages across globe just calling this nice command.
Zachary seems to be alive and active in some areas, so we may hope, he will accept the pull request and make this trivial change available on pypi.
Until then, you may install from my clone.

@vlcinsky
Copy link
Collaborator Author

@zacharyvoase: is there any chance, you would accept this pull request? Or reject?
Is there anything I could do about your great zmqc utility? It is very simple but powerful tool, so I would even volunteer taking over care of the zmqc package, if it would sound acceptable to you.
Simple installation over

$ pip install zmqc

is nice and practicat, without your step forward I would have to instruct my colleagues to install over git, what is less ideal solution.
Looking forward to your reaction.

@mloughran
Copy link

+1, this works for me

@amckinley
Copy link
Collaborator

+1, I was about to put up the same pull request. Really need to get this merged!

@zacharyvoase
Copy link
Owner

If anyone wants to take over this project I'd be happy to make them an admin on the Github repo. I can't really maintain zmqc these days :-/

@amckinley
Copy link
Collaborator

Sure, I can do that!
alt text

@vlcinsky
Copy link
Collaborator Author

I volunteer too. zmqc is really my daily swiss army knife and would be happy to keep it in such a shape, users could use it as easily as telnet. Also have few ideas for extending it (there is couple of new socket types since it was written) but I do not want to overpromise.

For me it is not important, that I am the maintainer, but that the zmqc can be updated on pypi in timely manner, so if someone else like@amckinley is feeling to be ready to react to possible pull requests within few weeks, I would be happy with that.

This leads to additional request - hand over (or allow to share) publishing to pypi.

@zacharyvoase
Copy link
Owner

The PyPI one seems to be a lot harder…I need to figure out what I can do to delegate access to that.

@vlcinsky
Copy link
Collaborator Author

@zacharyvoase Quick search did not show direct answer, but my feeling, that some packages are having multiple owners seems correct, e.g.: https://pypi.python.org/pypi/zuul/2.0.0

Anyway, I appreciate your will to move on with zmqc, I am sure many users will find again the power hidden in such simple tool.

vlcinsky added a commit that referenced this pull request Jun 18, 2014
Resolved problem with import of int_sockopts which were moved from core to sugar
@vlcinsky vlcinsky merged commit cbca4eb into zacharyvoase:master Jun 18, 2014
@vlcinsky
Copy link
Collaborator Author

@zacharyvoase

To set another person as Owner or Maintainer of PyPi package

To allow myself updating zmqc on pypi, the process goes as follows:

  1. go to https://pypi.python.org
  2. log into your account
  3. pick the zmqc package (right top part of the screen)
  4. select option "roles"
  5. add myself (as vlcinsky) with "Maintainer" role.
  6. submit
  7. let me know you are done

Testing the role procedure on bflmpsvz package

I did test this procedure (using my accounts vlcinsky and jan.vlcinsky on package https://pypi.python.org/pypi/bflmpsvz/0.1.1

If you like, you may clone the package from https://github.com/vlcinsky/bflmpsvz, update and publish an update (but before let me know your account name on pypi)

On PyPi I have tried giving access to bflmpsvz for disturbyte, zacharyvoase and zachary.voase but all have reported "user name not known".

My plans with zmqc package on pypi

  1. publish version zmqc 0.1.1 (see master tip of this repository where it is already pulled)
  2. Possibly make the package compatible with Python 3
  3. Possibly convert the setup.py to use pbr (to make versioning based on git tags)

All the time I want to:

  1. keep the UNLICENSE "License"
  2. keep you as package author (possibly adding myself somewhere around).

Let me know if you have any objections, want me to consult with you all these changes or you simply let me follow up with the great zmqc package in any way I find practical without bothering you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants