Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AllowedFlags): Adds allowed_flags option #59

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

sezaru
Copy link
Contributor

@sezaru sezaru commented Jun 8, 2023

Contributor checklist

  • My commit messages follow the Conventional Commit Message Format
    For example: fix: Multiply by appropriate coefficient, or
    feat(Calculator): Correctly preserve history
    Any explanation or long form information in your commit message should be
    in a separate paragraph, separated by a blank line from the primary message
  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@sezaru
Copy link
Contributor Author

sezaru commented Jun 8, 2023

This PR is related to the issue #57

Copy link
Owner

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should add the config I mentioned.

@sezaru
Copy link
Contributor Author

sezaru commented Jun 8, 2023

Maybe like this?

config :git_ops,
  tags: [
    allow_untagged?: true
    allowed: []
  ]

@zachdaniel zachdaniel merged commit 6260274 into zachdaniel:master Jun 9, 2023
@sezaru sezaru deleted the add_allowed_tags_option branch June 9, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants