Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nested tabs? #2

Open
greatislander opened this issue Feb 27, 2021 · 1 comment
Open

Support for nested tabs? #2

greatislander opened this issue Feb 27, 2021 · 1 comment

Comments

@greatislander
Copy link

Hi @zachleat! I'm wondering if you'd be open to a PR to add support for nested tabs for this component? The changes needed are fairly minor. Here's a codepen (JavaScript changes are on lines 12, 13, and 60):

https://codepen.io/greatislander/pen/GRNxgZY

Let me know— if that's outside of your intended scope, no worries!
@zachleat
Copy link
Owner

zachleat commented Mar 12, 2021 •
edited
Loading

Yeah absolutely! I’d love a PR!

greatislander added a commit to greatislander/seven-minute-tabs that referenced this issue Mar 15, 2021
@greatislander
Support nested seven-minute-tab components (resolves zachleat#2)
c12deab
@greatislander greatislander mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachleat @greatislander