Feature/required args #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
zachspar
commented
Jul 3, 2022
zachspar
commented
- Finish first full impl of all APIs
- Add args validation to all APIs
zachspar
added a commit
that referenced
this pull request
Jul 15, 2022
* create api decorator to check valid args * format files * add args validation for releases * add api arg validator for categories * update required args for categories namespace * add required args to tags namespace * add validate args to sources apis * add arg validation to series namespace * add required args for series apis * finish base implementation of all APIs, closes issue #4 * bump fred-py-api to 0.0.5 and update readme to point to wiki
zachspar
added a commit
that referenced
this pull request
Oct 8, 2022
* boilerplate cli * wrap sources cli * Feature/required args (#10) * create api decorator to check valid args * format files * add args validation for releases * add api arg validator for categories * update required args for categories namespace * add required args to tags namespace * add validate args to sources apis * add arg validation to series namespace * add required args for series apis * finish base implementation of all APIs, closes issue #4 * bump fred-py-api to 0.0.5 and update readme to point to wiki * Create dependabot.yml * Delete dependabot.yml * Feature/test suite (#11) * basic tests for categories namespace * add basic tests for tags api * add basic tests for sources api namespace * create basic tests for releases api namespace * add basic tests for series api namespace * create test for decorators * use src for tests * first full test-suite of basic API functionality, closes issue #8 * new CI for lint and test package * upgrade black in CI, use fred api key from GH secrets * reformat files * update CI only test for 3.9 & 3.10 * only run CI with python 3.10.x * run ci using coverage * add coverage upload * add new job skeleton to CI * upload to PyPI when publishing new release/prerelease * Feature/test suite (#14) * basic tests for categories namespace * add basic tests for tags api * add basic tests for sources api namespace * create basic tests for releases api namespace * add basic tests for series api namespace * create test for decorators * use src for tests * first full test-suite of basic API functionality, closes issue #8 * new CI for lint and test package * upgrade black in CI, use fred api key from GH secrets * reformat files * update CI only test for 3.9 & 3.10 * only run CI with python 3.10.x * run ci using coverage * add coverage upload * add new job skeleton to CI * upload to PyPI when publishing new release/prerelease * update readme * 0.0.7-Alpha (#16) * add FRED urls to python docstrings * update readme * bump lib * fix issue #15 by enforcing API length * check alnum * update tests * reformat file * rename top level packagename to fred * bump lib (#17) * Add support for XML `file_type` (#18) * add XML support, and associated test * bump lib version to v0.1.1 * move cli library * cli WIP * general idea of FRED cli, WIP * variadic api arguments and kwargs generator, import cleanups * re-organize internal util module * full CLI project skeleton with some working examples * json dump string in sources CLI * restructure tests module * adding dummy test case for codecov * adding dummy test case for codecov * reformat file * update ci to run coverage with src * add test for generate_api_kwargs cli utility * Added JSON CLI commands for each command * update tests module to use installed fred library * update local requirements * update cli code slightly * update pyproject.toml to include new deps and script entrypoints * update README to include CLI * update github ci workflow to include editable install * Fixed many issues in code review, still need 4 utility functions, few changes needed * update a few args, docstrings, and file format * Adding basic testing structure for sources cli * wip series test cases * refactor fred cli entry point * refactor common test case logic * refactor and fix existing api tests * fix api key mock for cli tests * update ci workflow * slight refactor to base fred client test setup * allow for more testing constraints in base framework * wip series cli tests * omit test * add all basic tests for releases namespace * add missing test to releases namespace * finish up all basic tests for series cli * add support for XML output in CLI * Added CLI test cases for sources, tags, categories * reformat files * fix up some broken tests * add new test for CLI entry point * optimize imports * update codecoverage omit files, and CI * fix CI * ignore unnecessary files in codecov * update pyproject.toml description Co-authored-by: Zachary Spar <zachspar@gmail.com> Co-authored-by: Zachary Spar <41600414+zachspar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.