issue # 7 - Repeat Field inside editor #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackify
reviewed
May 8, 2018
| this.setState(function (prevState, props) { | ||
| return { items: prevState.items + 1 } | ||
| }, () => { | ||
| this.props.setAttributes && this.add(); |
There was a problem hiding this comment.
Okay, I see what you meant no need for local state because we can just set a new empty item 👍
|
Used what you had to make it not use state at all, thanks. Only thing is that it has to use I might add a HOC so you dont have to do this in the editor, like editor-repeat that has the context and passes in the onChange and attributes |
|
ok actually did it, so check this out https://github.com/crossfield/gutenblock/releases/tag/0.6.5 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.