Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search implementation #37

Merged
merged 23 commits into from
Feb 18, 2020
Merged

Search implementation #37

merged 23 commits into from
Feb 18, 2020

Conversation

ianmcclean
Copy link
Collaborator

This PR is built off of #35 as it needed the web scraping functionality.

Issue closed:
#30

List of changes:

  • Added basic search functionality from AllRecipes
  • Made a FoodBlocks component to display the cards with food titles
    This should be used whenever a foodblock is rendered so there is no code reuse

This was referenced Feb 10, 2020
@ianmcclean
Copy link
Collaborator Author

This now encapsulates issues #31 as well as #30

Copy link
Owner

@zaffrew zaffrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Larry Page!

@ianmcclean ianmcclean merged commit eb947da into master Feb 18, 2020
@ianmcclean ianmcclean deleted the search-implementation branch February 18, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants