Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequencial optional #71

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Fix sequencial optional #71

merged 3 commits into from
Jun 23, 2020

Conversation

zaibacu
Copy link
Owner

@zaibacu zaibacu commented Jun 23, 2020

Closes #69

Turns out it is a bug related to - character which in most cases used as a splitter, but in this case as a stand alone word

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #71 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   93.03%   93.05%   +0.02%     
==========================================
  Files          11       11              
  Lines         617      619       +2     
  Branches      104      105       +1     
==========================================
+ Hits          574      576       +2     
  Misses         29       29              
  Partials       14       14              
Impacted Files Coverage Δ
rita/preprocess.py 99.24% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba17cdf...f0b3b2b. Read the comment docs.

@zaibacu zaibacu merged commit 93252c2 into master Jun 23, 2020
@zaibacu zaibacu deleted the fix-sequencial-optional branch June 23, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence of optional macros behaves incorrectly
1 participant