Fix Decimal typecasting directly after setting. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directly after setting a decimal attribute, the attribute reader return a String instead of a BigDecimal. This changes force the attribute reader to read the value before typecast when it has not yet been saved. More details: #34
Improve Decimal typecasting
YannIsCoding
force-pushed
the
bug/serialize_bigdecimal
branch
from
cd23ef2
to
d644148
Compare
|
@nickcampbell18 Are you happy with this? Should I merge? |
YannIsCoding
force-pushed
the
bug/serialize_bigdecimal
branch
from
7170de4
to
d5741ff
Compare
nickcampbell18
approved these changes
Jun 1, 2022
YannIsCoding
force-pushed
the
bug/serialize_bigdecimal
branch
from
d5741ff
to
2a48188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly after setting a decimal attribute, the attribute reader return a String instead of a BigDecimal.
These changes check if the typecasting is correct in the writer method and force the attribute reader to read the value before typecast if it's not.
Note that these changes only affect the scenario when the attribute is read directly after being saved. The behavior when loading data from the DB was correct and is left unchanged.
More details:
#34