Add invalid bounds checking #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases there can be layers without bounds, for example, empty polylines (in general - paths) made for dynamic changes or workarounds, like makinacorpus/Leaflet.TextPath#83. This fix prevents later exceptions on bounds relation calculation.
|
@zakjan could you please take a look at it and if you do not have any comments, merge & release? Thanks |
|
Thanks! Published as 2.2.5 |
|
By any chance, this bug doesn't happen for you? #41 |
|
"Unfortunately" no, but I am using leaflet 1.5.1 |
|
Interesting. It happens in the demo even with Leaflet 1.5.1. What's your MarkerCluster version? |
|
1.4.1, I have my own cluster icon/tooltip also - maybe this is related. |
|
Ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases there can be layers without bounds, for example, empty polylines (in general - paths) made for dynamic changes or workarounds, like makinacorpus/Leaflet.TextPath#83. This fix prevents later exceptions on bounds relation calculation.