config: move provider id enum into config package #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move enum into config package to avoid import cycle and eliminate duplicate string literals. Follow up on https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/765/files#r1601499528 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
I was tempted to do this in my original PR, but didn't because it seems to me it makes more sense that this ID is in the |
gargravarr
reviewed
May 15, 2024
| const ( | ||
| // ZalandoAWS Provider is the provider ID for Zalando managed AWS clusters. | ||
| ZalandoAWSProvider ProviderID = "zalando-aws" | ||
| ) |
There was a problem hiding this comment.
nit: have a single const block.
|
I think its fine both ways so no need to change it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move enum into config package to avoid import cycle and eliminate duplicate string literals.
Follow up on https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/765/files#r1601499528