Skip to content

Commit

Permalink
Sync annotation and improve naming in golden file tests
Browse files Browse the repository at this point in the history
Signed-off-by: Lucas Thiesen <lucas.thiesen@zalando.de>
  • Loading branch information
lucastt committed Oct 30, 2023
1 parent 4aff9d3 commit 5618b11
Show file tree
Hide file tree
Showing 11 changed files with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: myingress
annotations:
zalando.org/aws-load-balancer-shared: "true"
spec:
rules:
- host: foo.bar.org
Expand All @@ -13,4 +15,4 @@ spec:
port:
name: main-port
path: /
pathType: ImplementationSpecific
pathType: ImplementationSpecific
4 changes: 3 additions & 1 deletion testdata/ingress_rg_shared_alb/input/k8s/01-ing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: myingress
annotations:
zalando.org/aws-load-balancer-shared: "true"
spec:
rules:
- host: foo.bar.org
Expand All @@ -13,4 +15,4 @@ spec:
port:
name: main-port
path: /
pathType: ImplementationSpecific
pathType: ImplementationSpecific
4 changes: 3 additions & 1 deletion testdata/ingress_rg_shared_nlb/input/k8s/01-ing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: myingress
annotations:
zalando.org/aws-load-balancer-shared: "true"
spec:
rules:
- host: foo.bar.org
Expand All @@ -13,4 +15,4 @@ spec:
port:
name: main-port
path: /
pathType: ImplementationSpecific
pathType: ImplementationSpecific
2 changes: 1 addition & 1 deletion worker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ func TestResourceConversionOneToOne(tt *testing.T) {
},
typeLB: awsAdapter.LoadBalancerTypeNetwork,
}, {
name: "ingress_rg_notshared_alb",
name: "ing_shared_rg_notshared_alb",
responsesEC2: fake.EC2Outputs{DescribeInstancesPages: fake.MockDescribeInstancesPagesOutput(
nil,
fake.TestInstance{
Expand Down

0 comments on commit 5618b11

Please sign in to comment.