Remove FabricGateway support #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial support #474 was implemented as a part of an effort to make FabricGateway a Skipper-native route format. Since then the approach has changed and there is a plan to use a new controller that would translate FabricGateway into equivalent RouteGroup. Since RouteGroups are natively supported by Skipper and Ingress Controller there is no need to keep track of the FabricGateway loadbalancer name in the status. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
remove-fabric-support
branch
from
425a9c4
to
268c4b2
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support #474 was implemented as a part of an effort to make
FabricGateway a Skipper-native route format.
Since then the approach has changed and there is a plan to use a new controller
that would translate FabricGateway into equivalent RouteGroup.
Since RouteGroups are natively supported by Skipper and Ingress
Controller there is no need to keep track of the FabricGateway
loadbalancer name in the status.
Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de