Make Resource conversion tests also check params and tags #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Thiesen <lucas.thiesen@zalando.de>
lucastt
force-pushed
the
fix-goldenfiles-tests
branch
from
804699e
to
0354686
Compare
… test Signed-off-by: Lucas Thiesen <lucas.thiesen@zalando.de>
|
👍 |
|
👍 |
|
Marked as do-not-merge until we decide if we merge to master or a feature branch |
|
👍 |
|
@AlexanderYastrebov I think in this case there is only test changed, so no production code path can change so we can also merge it to master IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes should fix the current behavior of golden file tests that do not really check important parameters and only check the correctness of the template, which is not really testing the stack generation algorithm of the ingress controller.
#626