Feature: nlb zone affinity via r53 #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables you to set dns_record.client_routing_policy configuration, such that you can decide for NLB via R53 feature that clients running in the same zone will hit also the same zone of your NLB. This is interesting for cross cluster traffic or traffic that stays in the same cluster but passes the NLB. Valid configurations are: - availability_zone_affinity - partial_availability_zone_affinity - any_availability_zone (default) see also https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html\#load-balancer-attributes and https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html\#zonal-dns-affinity Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
|
I want to test in a dev cluster before merge |
| @@ -124,6 +125,10 @@ const ( | |||
| DefaultAlbS3LogsPrefix = "" | |||
|
|
|||
| DefaultCustomFilter = "" | |||
|
|
|||
| // DefaultZoneAffinity specifies dns_record.client_routing_policy, see also https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html#load-balancer-attributes | |||
| DefaultZoneAffinity = "any_availability_zone" | |||
There was a problem hiding this comment.
| // availability_zone_affinity 100% | ||
| // partial_availability_zone_affinity 85% | ||
| // any_availability_zone 0% | ||
| Value: cloudformation.String(spec.nlbZoneAffinity), |
There was a problem hiding this comment.
Here we assume it has a valid value. Do we need to check if it is not empty?
There was a problem hiding this comment.
This is always set. In cf_template we should never check the values, only if we need to delete the attribute we need to check.
|
LGTM modulo minor comments. |
|
👍 |
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
|
👍 |
1 similar comment
|
👍 |
|
Default: With zone affinity set: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: set nlb zone affinity for clients
log: log default cross zone and zone affinity config
This enables you to set dns_record.client_routing_policy configuration, such that you can decide for NLB via R53 feature that clients running in the same zone will hit also the same zone of your NLB. This is interesting for cross cluster traffic or traffic that stays in the same cluster but passes the NLB. Valid configurations are:
see also https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html\#load-balancer-attributes and https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html\#zonal-dns-affinity