build image using multi-stage builds #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@linki if you make a PR from a local branch then CDP will run on the PR :) |
mikkeloscar
reviewed
Jun 19, 2017
Dockerfile
Outdated
| WORKDIR /go/src/github.com/zalando-incubator/kube-ingress-aws-controller | ||
| COPY . . | ||
| RUN glide install --strip-vendor | ||
| RUN make build.linux |
There was a problem hiding this comment.
I would also run make test before the build.
|
@mikkeloscar Thanks, don't know why I used a fork here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Docker's new multi-stage dockerfiles to build.
It builds the binary inside a Docker containe and avoids cluttering the host machine with stuff. By using the new build stages this can conveniently be run with a simple
docekr build.unrelated: I consistently change any reference to the project to
kube-ingress-aws-controller.