Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sql/strip-prefixes #103

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Remove sql/strip-prefixes #103

merged 1 commit into from
Apr 30, 2019

Conversation

ethercrow
Copy link
Contributor

Postgres can already do that.

harti2006
harti2006 reviewed Apr 30, 2019
View reviewed changes
resources/db/applications.sql Outdated
a_created_by as created_by,
a_last_modified as last_modified,
a_last_modified_by as last_modified_by,
a_publicly_accessibl as publicly_accessiblee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo :-P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@ethercrow ethercrow force-pushed the remove-regexing-of-sql-results branch from 6294ce2 to db2ac74 Compare April 30, 2019 09:47
@aermakov-zalando
Copy link
Contributor

👍

1 similar comment
@ethercrow
Copy link
Contributor Author

👍

@ethercrow ethercrow merged commit a087aab into zalando-stups:master Apr 30, 2019
@ethercrow ethercrow deleted the remove-regexing-of-sql-results branch April 30, 2019 10:52
@hjacobs hjacobs mentioned this pull request May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harti2006 harti2006 harti2006 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethercrow @aermakov-zalando @harti2006