Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits of bimg #160

Open
axyz opened this issue Dec 19, 2018 · 0 comments
Open

Limits of bimg #160

axyz opened this issue Dec 19, 2018 · 0 comments

Comments

@axyz
Copy link

axyz commented Dec 19, 2018

Currently skrop is strictly coupled with bimg for all the image processing.

While bimg provides a good coverage for the basic operations it is a very limited wrapper on top of all the vips capabilities.

Ideally would be nice to use vips bindings directly. Of course bimg comes out of the box with some nice abstractions and wrappers to overcame the nightmare of all the segmentation faults that we may have using the bindings directly.

One option may be to just copy the part of bimg that we need, or to fork it.

A concrete example of the limits is customizing the jpeg encoding settings.
we cannot pass down the no_subsample option, leading to very poor quality for compressions lower than 85, also we cannot use different quantization tables (mozjpeg one may lead to better quality), and some other advanced settings that could allow us to fine tune the quality and the size of the images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant