Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ztoken" fails for SSO #21

Closed
hjacobs opened this issue Dec 14, 2016 · 3 comments
Closed

"ztoken" fails for SSO #21

hjacobs opened this issue Dec 14, 2016 · 3 comments
Assignees
@hjacobs
Labels
bug

Comments

@hjacobs
Copy link
Contributor

hjacobs commented Dec 14, 2016 •
edited
Loading

ztoken will fail if OAuth provider uses SSO and directly redirects back to localhost:

Browser error (localhost server already shut down):

This site can’t be reached

localhost refused to connect.
@hjacobs hjacobs added the bug label Dec 14, 2016
@hjacobs
Copy link
Contributor Author

hjacobs commented Dec 14, 2016

Needs some investigation..

@hjacobs hjacobs self-assigned this Dec 14, 2016
hjacobs added a commit that referenced this issue Dec 14, 2016
@hjacobs
#21 handle requests until we get query params
9fbe309
@hjacobs hjacobs mentioned this issue Dec 14, 2016
Merged
@hjacobs
Copy link
Contributor Author

hjacobs commented Dec 14, 2016

The reason was simple: one extra request to favicon.ico...

@gargravarr
Copy link
Contributor

Nice catch!

hjacobs added a commit that referenced this issue Dec 14, 2016
@hjacobs
Merge pull request #22 from zalando-stups/handle-multiple-requests
387c982 
#21 handle requests until we get query params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjacobs hjacobs

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbellmann @hjacobs @gargravarr