Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Log exceptions thrown by API controllers #564

Open
elgris opened this issue Mar 14, 2018 · 0 comments
Open

Log exceptions thrown by API controllers #564

elgris opened this issue Mar 14, 2018 · 0 comments
Labels
bug user-reported issues that take more than one hour to resolve Revisit Relevant issue. Needs to be tackled as part of current stabilising work

Comments

@elgris
Copy link
Contributor

elgris commented Mar 14, 2018

User story

As a developer
I want controllers located in org.zalando.zmon.api log exceptions
So that I have better visibility on problems

Explanation

Some controller classes already have @ExceptionHandlers enabled. For instance

public class AlertDefinitionsApi extends AbstractZMonController

Where AbstractZMonController defines a bunch of @ExceptionHandlers

However other controller classes don't have any exception handlers, so when the exception is thrown, error message is returned to the client, but not logged by ZMON controller.

@beverage beverage added the bug user-reported issues that take more than one hour to resolve label Jul 17, 2018
@rajatparida86 rajatparida86 added the Revisit Relevant issue. Needs to be tackled as part of current stabilising work label Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug user-reported issues that take more than one hour to resolve Revisit Relevant issue. Needs to be tackled as part of current stabilising work
Projects
None yet
Development

No branches or pull requests

3 participants