Check for Vulnerabilities via GHE Action #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasmarian
reviewed
Jan 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
lukasniemeier-zalando
force-pushed
the
dependency-review
branch
from
b0db788
to
578a4c7
Compare
lukasniemeier-zalando
force-pushed
the
dependency-review
branch
from
578a4c7
to
261bf75
Compare
|
👍 |
|
We will try to address merges (push) and scheduled builds in a follow-up ! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for Vulnerabilities via GHE Action
Description
This pull request changes the way how we check for security advisories. We move to checking pull requests for introducing new vulnerabilities due to dependency changes via https://github.com/actions/dependency-review-action. Newly discovered vulnerabilities are continued to be reported via https://github.com/zalando/logbook/security/dependabot.
Motivation and Context
The
org.owasp.dependency-check-mavenplugin isn't working reliably anymore and an upgrade to its new version seems not to be feasible (requires API key, users still report slowness), hence we are looking for more streamlined options to make use of Github capabilities directly.We accept the fact that local builds are not scanned anymore, given that most developers were skipping it either way (due to the slowness).