Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bill of materials #288

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Added bill of materials #288

merged 1 commit into from
Jun 18, 2018

Conversation

whiskeysierra
Copy link
Collaborator

Description

Logbook has already 5+ modules that produce individual artifacts. Users that depend on them will usually list them all as dependencies in their POMs. Right now we guarantee that version numbers across modules are always the same, i.e. a new release will release each module, even if it wasn't change.
That allows users right now already to use a single maven property logbook.version that is used for each dependency.

This pull requests introduces a BOM (bill of material) as an alternative. The BOM can be imported in the dependencyManagement section of a POM.

Motivation and Context

The BOM removes the need to specify any version on individual logbook artifacts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@lukasniemeier-zalando
Copy link
Member

👍

@whiskeysierra whiskeysierra merged commit 16faa1b into master Jun 18, 2018
@whiskeysierra whiskeysierra deleted the feature/bom branch June 18, 2018 12:44
@rainermueller
Copy link
Contributor

rainermueller commented Nov 1, 2018

To omit the versions in pom.xml the dependencies in org.zalando:logbook-bom must define <version>${logbook.version}</version>

We still have to define the dependency version due to following error

[ERROR] 'dependencies.dependency.version' for org.zalando:logbook-servlet:jar is missing. @ com.inventage.demo:backend-war:[unknown-version]

@whiskeysierra
Copy link
Collaborator Author

Shouldn't the version be inherited from the parent?

@rainermueller
Copy link
Contributor

Compared to org.springframework:spring-framework-bom and others every dependency defines the version.

@whiskeysierra
Copy link
Collaborator Author

Would you mind creating a pull request?

@rainermueller
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants