This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
Support making DataLake annotations as mandatory upon creation and update of event type #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1u0
force-pushed
the
datalake-annotations
branch
4 times, most recently
from
0c87547
to
2583196
Compare
1u0
force-pushed
the
datalake-annotations
branch
3 times, most recently
from
2a9c54d
to
b4bcb7f
Compare
…ng feature toggle
1u0
force-pushed
the
datalake-annotations
branch
from
b4bcb7f
to
27da46f
Compare
1 task
1u0
changed the title
2 tasks
…ion is on (unconditionally of the feature toggle)
1u0
force-pushed
the
datalake-annotations
branch
from
b70bbf7
to
02a9e44
Compare
|
👍 |
adyach
reviewed
Feb 5, 2024
| " the error message should include the retention reason annotation name", | ||
| e.getMessage().contains(EventTypeAnnotationsValidator.RETENTION_REASON_ANNOTATION)); | ||
| Assert.assertTrue( | ||
| "When the retention period is specified but the retention reason is not," + |
There was a problem hiding this comment.
Suggested change
| "When the retention period is specified but the retention reason is not," + | |
| "When the retention reason is specified but the retention period is not," + |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Description
A few sentences describing the overall goals of the pull request's
commits.
Review
Deployment Notes
These should highlight any db migrations, feature toggles, etc.