fix: no switchover candidate found with member state "streaming" (#1992) #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootc
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
|
There is another possible state of a running replica - "in archive recovery" |
bootc
force-pushed
the
fix/switchover_member_state_streaming
branch
from
bfe2830
to
efc3b1f
Compare
|
👍 |
macedigital
reviewed
Jan 24, 2024
| continue | ||
| } | ||
|
|
||
| if slices.Contains([]string{"running", "streaming", "in archive recovery"}, member.State) { |
There was a problem hiding this comment.
The next part of the code sorts candidates by smallest amount of lag. My only concern with merging this change is that it might cause a switchover to a replica lagging behind significantly, as lag is not guaranteed to be 0.
Overall, this is still better than what we have now, though.
postgres-operator/pkg/cluster/pod.go
Lines 511 to 516 in 45489d3
There was a problem hiding this comment.
Patroni will prevent it if this is the case.
macedigital
approved these changes
Jan 24, 2024
macedigital
reviewed
Jan 24, 2024
| @@ -75,6 +75,13 @@ func TestGetSwitchoverCandidate(t *testing.T) { | |||
| expectedCandidate: spec.NamespacedName{}, | |||
| expectedError: fmt.Errorf("no switchover candidate found"), | |||
| }, | |||
| { | |||
| subtest: "replicas with streaming state", | |||
| clusterJson: `{"members": [{"name": "acid-test-cluster-0", "role": "leader", "state": "running", "api_url": "http://192.168.100.1:8008/patroni", "host": "192.168.100.1", "port": 5432, "timeline": 1}, {"name": "acid-test-cluster-1", "role": "replica", "state": "streaming", "api_url": "http://192.168.100.2:8008/patroni", "host": "192.168.100.2", "port": 5432, "timeline": 1, "lag": 5}, {"name": "acid-test-cluster-2", "role": "replica", "state": "streaming", "api_url": "http://192.168.100.3:8008/patroni", "host": "192.168.100.3", "port": 5432, "timeline": 1, "lag": 2}]}`, | |||
There was a problem hiding this comment.
We might want to add test cases to capture "in archive recovery" mode, eventually.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1992