Cleanup of IdempotencyPlugin declaration #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatroom
requested review from
AlexanderYastrebov,
lukasniemeier-zalando,
patandrick and
whiskeysierra
as code owners
|
Good catch! The proper fix would be to just remove this file: https://github.com/zalando/riptide/blob/master/riptide-idempotency/src/main/resources/META-INF/services/org.zalando.riptide.Plugin |
fatroom
changed the title
|
Adjusted accordingly :) |
|
👍 |
|
Thanks for the contribution! I'm releaseing 3.0.0-RC.2 right now 📦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of IdempotencyPlugin declaration
Motivation and Context
As soon as I got riptide-idempotence in my class path, I can not create simple http client without specifying plugins any more. Default plugin resolver see plugin declaration in META-INF.services but fails to find actual class, which leads to
ServiceConfigurationException: org.zalando.riptide.Plugin: Provider org.zalando.riptide.idempotency.IdempotencyPlugin not found.Types of changes
Checklist: