config: add yaml flag #3069
Merged
config: add yaml flag #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
reviewed
May 7, 2024
YAML flag parses (preferably flow-style) YAML value from the command line
or unmarshals object yaml value from the yaml config file.
Example value:
```
bin/skipper -foo-flag='{foo: hello, bar: [world, "1"], baz: 2, qux: {baz: 3}}'
```
and equivalent branch in config yaml:
```yaml
foo-flag:
foo: hello
bar:
- world
- "1"
baz: 2
qux:
baz: 3
```
This will be useful for #2104
It is also a better alternative to manual parsing of micro-syntax like
e.g. implemented in #2888
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
config/yaml-flag
branch
from
2503211
to
174cd01
Compare
szuecs
reviewed
May 7, 2024
| ) | ||
|
|
||
| type yamlFlag[T any] struct { | ||
| Ptr **T |
There was a problem hiding this comment.
The usage looks like
type Config struct {
OpenTelemetry *otel.Options `yaml:"open-telemetry"`
...
}
...
flag.Var(newYamlFlag(&cfg.OpenTelemetry), "open-telemetry", "OpenTelemetry configuration in YAML format, use flow-style for convenience")
...
if o.OpenTelemetry != nil {
...
}The value is allocated when flag is set and stays nil when it is not, i.e. this allows to tell if flag was provided.
|
👍 |
1 similar comment
|
👍 |
This was referenced May 13, 2024
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
YAML flag parses (preferably flow-style) YAML value from the command line
or unmarshals object yaml value from the yaml config file.
Example value:
```
bin/skipper -foo-flag='{foo: hello, bar: [world, "1"], baz: 2, qux: {baz: 3}}'
```
and equivalent branch in config yaml:
```yaml
foo-flag:
foo: hello
bar:
- world
- "1"
baz: 2
qux:
baz: 3
```
This will be useful for zalando#2104
It is also a better alternative to manual parsing of micro-syntax like
e.g. implemented in zalando#2888
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML flag parses (preferably flow-style) YAML value from the command line or unmarshals object yaml value from the yaml config file.
Example value:
and equivalent branch in config yaml:
This will be useful for #2104
It is also a better alternative to manual parsing of micro-syntax like e.g. implemented in #2888