config: support multiple default filters flag values #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
|
👍 |
AlexanderYastrebov
force-pushed
the
config/support-multiple-default-filters
branch
from
9c5e697
to
4313a94
Compare
This is useful for templated configurations that conditionally add various default filters. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
config/support-multiple-default-filters
branch
from
4313a94
to
a3695f1
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Jun 6, 2024
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 25, 2024
Do not store values that contaion no filters, e.g. empty strings or eskip comments only. Follow up on #3084 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 25, 2024
Do not store values that contaion no filters, e.g. empty strings or eskip comments only. Follow up on #3084 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
This is useful for templated configurations that conditionally add various default filters. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for templated configurations that conditionally add various default filters.