Skip to content

Commit

Permalink
Bump wal-g version to v3.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@hughcapet
hughcapet committed Mar 18, 2024
1 parent 00d2f54 commit 4533ded
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion postgres-appliance/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ FROM $BASE_IMAGE as dependencies-builder

ARG DEMO

ENV WALG_VERSION=v2.0.1
ENV WALG_VERSION=v3.0.0

COPY build_scripts/dependencies.sh /builddeps/

Expand Down

1 comment on commit 4533ded

@altemans
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, you tested deleting a backup with an upgrade of the wal-g version in the script postgres_backup.sh ?
I changed the script in my build for myself and I have a suspicion that in the current version, the deletion will never be performed, because the result of wal-g backup-list returns the following result

# $WAL_E backup-list
INFO: 2024/03/26 16:17:43.195817 List backups from storages: [default]
backup_name modified wal_file_name storage_name
base_000000160000000100000090 2024-03-26T00:15:07+03:00 000000160000000100000090 default
base_00000001000000000000000B 2024-03-26T16:07:06+03:00 00000001000000000000000B default
#

as a result, the query returns an empty string

# $WAL_E backup-list 2> /dev/null | id '0,/^name\s*\(last_\)\?modified\s*/d'
#

but if you change the sed, we get a list

# $WAL_E backup-list 2> /dev/null | sed '0,/^.*name\s*\(last_\)\?modified\s*/d'
base_000000160000000100000090 2024-03-26T00:15:07+03:00 000000160000000100000090 default
base_00000001000000000000000B 2024-03-26T16:07:06+03:00 00000001000000000000000B default

the old way to return the result

# wal-g backup-list
name modified wal_segment_backup_start
base_000000160000000100000090 2024-03-26T00:15:07+03:00 000000160000000100000090
base_00000001000000000000000B 2024-03-26T16:07:06+03:00 00000001000000000000000B

Please sign in to comment.