Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Issue-1019 Update helm chart zip files to release version 3.141.59t #1020

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Issue-1019 Update helm chart zip files to release version 3.141.59t #1020

merged 1 commit into from
Jul 30, 2019

Conversation

ramapalani
Copy link
Contributor

@ramapalani ramapalani commented Jul 26, 2019 •
edited
Loading

Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.

Description

Detailed description here in the issue: #1019

Motivation and Context

Ideally it would be great if I could a release version of helm charts from an artifact repository. Next best is to get it release version of artifacts as compressed file in the git repo. The file that is currently there does not have the latest version. This PR updates that.

How Has This Been Tested?

I uncompressed the new file, and was able to deploy.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
    No code change
  • [ x] My change requires a change to the documentation.
    No need for additional documentation
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

Codecov Report

Merging #1020 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1020      +/-   ##
============================================
+ Coverage     54.99%   55.58%   +0.59%     
- Complexity      675      680       +5     
============================================
  Files            58       58              
  Lines          4562     4562              
  Branches        429      429              
============================================
+ Hits           2509     2536      +27     
+ Misses         1818     1790      -28     
- Partials        235      236       +1

diemol
diemol approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramapalani!

@diemol diemol merged commit b6e7736 into zalando:master Jul 30, 2019
@diemol diemol mentioned this pull request Jul 30, 2019
Closed
@boxcee boxcee mentioned this pull request Jul 30, 2019
Closed
@boxcee
Copy link

boxcee commented Jul 30, 2019 •
edited
Loading

@ramapalani & @diemol is the trailing 't' in the filename expected?

Edit: I see it is. But did you possibly delete the actual 3.141.59 then?

@abuokoene
Copy link

@ramapalani & @diemol is the trailing 't' in the filename expected?

Edit: I see it is. But did you possibly delete the actual 3.141.59 then?

Or possibly, should the index.yaml file be updated to the correct filename (with the 't')?

@ramapalani
Copy link
Contributor Author

I named the file same as the release name.
@diemol & @boxcee how should I address these, I see two options

  • option 1: Change the file name to 3.141.59 (without t)
  • option 2: Update zalenium/chart.yaml with version 3.141.59t

I would prefer option1, as the release branch doesn't have t in the chart.yaml

@boxcee
Copy link

boxcee commented Jul 31, 2019

@diemol & @ramapalani, can we not have both? For backwards compatibility reasons you should definitely not have a 3.141.59t in a 3.141.59 chart. That is confusing.

Ideally you then also add the 3.141.59t to the index and the repo.

@ramapalani
Copy link
Contributor Author

ramapalani commented Jul 31, 2019 •
edited
Loading

Looks like @sharkymcdongles fixed it through this PR #1025

Is there anything required further on this?

jlamaille pushed a commit to jlamaille/zalenium that referenced this pull request Sep 12, 2019
@ramapalani @jlamaille
Issue-1019 Update helm chart zip files to release version 3.141.59t (z…
93696a8 
…alando#1020)
diemol pushed a commit that referenced this pull request Sep 15, 2019
@jlamaille @diemol
Fix get hostname dns load (#1048)
12fa8d2 
* Release 3.141.59t

* Add empty default value for podSecurityContext and containerSecurityContext (#1016)

Co-Authored-By: Pirmin Schuermann <pirmin.schuermann@gmail.com>

* Issue-1019 Update helm chart zip files to release version 3.141.59t (#1020)

* fixed index file (#1025)

* Change probes URL to the /status page (#1024)

When creating the console page, Zalenium servlet collects the status of all the nodes. If some of the nodes' proxy is unavailable, then the probe will fail. Using status page makes the Hub probes not relying on the state, health and availability of the node pods.

* Fix condition to get container by remote url

* Add symlink for /usr/bin/docker in Dockerfile

* Rewrite condition to exec ./zalenium.sh in entry.sh considering none sudo

* Update docker swarm documentation

* allow the modification of the hosts file inside a container

* Add documentation for hostAliases

* Fix get pod ip dns load error
@arushi-29 arushi-29 mentioned this pull request Aug 18, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramapalani @codecov-io @boxcee @abuokoene @diemol