Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove violation in case of successive parameters for Rule 143 #1260

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Jun 23, 2021

Rule 241 relaxes requirements of Rule 143 and allows to define compound keys successive parameters.

Fixes #1182

@vadeg vadeg changed the title Remove violation in case of successive parameters for rule 143 Remove violation in case of successive parameters for Rule 143 Jun 23, 2021
Rule 241 relaxes requirements and allows to define compound keys successive parameters.
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #1260 (b3d2920) into master (750a31c) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1260      +/-   ##
============================================
- Coverage     76.09%   76.01%   -0.09%     
+ Complexity      973      972       -1     
============================================
  Files           187      187              
  Lines          2878     2868      -10     
  Branches        502      502              
============================================
- Hits           2190     2180      -10     
  Misses          427      427              
  Partials        261      261              
Impacted Files Coverage Δ
...uleset/zalando/IdentifyResourcesViaPathSegments.kt 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750a31c...b3d2920. Read the comment docs.

@tkrop
Copy link
Member

tkrop commented Jun 24, 2021

👍

Copy link
Member

@tkrop tkrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thank you.

@vadeg
Copy link
Contributor Author

vadeg commented Jun 24, 2021

👍

@vadeg vadeg merged commit a5cf2fe into master Jun 24, 2021
@tkrop tkrop deleted the gh-1182-remove-successive-params-check branch July 6, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow compound keys in identifiers (#557)
3 participants