Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional flag to skip SSL request verification #1270

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Jun 28, 2021

Fixes #1185

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #1270 (997339a) into master (a343dbe) will increase coverage by 11.37%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1270       +/-   ##
=============================================
+ Coverage     75.98%   87.36%   +11.37%     
+ Complexity      984       85      -899     
=============================================
  Files           187       52      -135     
  Lines          2886      633     -2253     
  Branches        506       71      -435     
=============================================
- Hits           2193      553     -1640     
+ Misses          429       57      -372     
+ Partials        264       23      -241     
Impacted Files Coverage Δ
...zalando/zally/ruleset/zalando/EnumValueTypeRule.kt
.../java/org/zalando/zally/apireview/RuleViolation.kt
...o/zally/ruleset/zalando/model/ZallyOpenApiModel.kt
...n/kotlin/org/zalando/zally/core/AbstractRuleSet.kt
...uleset/zalando/IdentifyResourcesViaPathSegments.kt
.../org/zalando/zally/statistic/ViolationStatistic.kt
...lin/org/zalando/zally/core/util/OpenApiSections.kt
.../zally/ruleset/zalando/VersionInInfoSectionRule.kt
...java/org/zalando/zally/dto/ApiDefinitionRequest.kt
...zally/configuration/RulesValidatorConfiguration.kt
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a343dbe...997339a. Read the comment docs.

@tkrop
Copy link
Member

tkrop commented Jun 29, 2021

👍

1 similar comment
@vadeg
Copy link
Contributor Author

vadeg commented Jun 29, 2021

👍

@vadeg vadeg merged commit 37fa75b into master Jun 29, 2021
@vadeg vadeg deleted the gh-1185-add-skip-ssl-flag branch June 29, 2021 07:45
@tkrop tkrop added type: enhancement area: cli Issue with a Command Line Tool labels Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli Issue with a Command Line Tool type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use CLI against server with self signed SSL certificate
3 participants