Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change severity of proprietary header rule (#1367) #1367

Merged
merged 1 commit into from
Mar 3, 2022
Merged

feat: change severity of proprietary header rule (#1367) #1367

merged 1 commit into from
Mar 3, 2022

Conversation

tkrop
Copy link
Member

@tkrop tkrop commented Mar 2, 2022

It seems we have overlooked a two years old guideline change on the severity of proprietary header usage that was changed from MUST to SHOULD (see https://opensource.zalando.com/restful-api-guidelines/#183).

@tkrop tkrop requested a review from zeitlinger as a code owner March 2, 2022 18:06
@tkrop tkrop requested a review from vadeg March 2, 2022 18:07
@tkrop tkrop self-assigned this Mar 2, 2022
@tkrop tkrop added area: rules guidelines-update Automatically created Issue for changes in the API guidelines → check for zally-change label rule change Guideline change needs a corresponding Zally rule change labels Mar 2, 2022
@tkrop
Copy link
Member Author

tkrop commented Mar 2, 2022

👍

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022 •
edited
Loading

Codecov Report

Merging #1367 (1a9a9ce) into main (c50eb5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          49       49           
  Lines         734      734           
  Branches       55       55           
=======================================
  Hits          642      642           
  Misses         63       63           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50eb5d...1a9a9ce. Read the comment docs.

@hjacobs
Copy link

hjacobs commented Mar 2, 2022

👍

@tkrop tkrop merged commit 942abdf into main Mar 3, 2022
@tkrop tkrop deleted the 1367-change-sevirity-of-propriatary-header-rule branch March 3, 2022 12:24
tkrop added a commit that referenced this pull request Mar 9, 2022
@tkrop
fix: missing annotation changes (#1367)
6140e4d
@tkrop tkrop mentioned this pull request Mar 9, 2022
Merged
tkrop added a commit that referenced this pull request Mar 9, 2022
@tkrop
Merge pull request #1368 from zalando/1367-change-sevirity-of-propria…
13b6be7 
…tary-header-rule

fix: missing annotation changes (#1367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger Awaiting requested review from zeitlinger

@vadeg vadeg Awaiting requested review from vadeg

Assignees

@tkrop tkrop

Labels
area: rules guidelines-update Automatically created Issue for changes in the API guidelines → check for zally-change label rule change Guideline change needs a corresponding Zally rule change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkrop @codecov-commenter @hjacobs