Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProprietaryHeadersRuleTest.kt #1405

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

caliginouspierson
Copy link
Contributor

Fixes #1404

validateResponseHeaders should return no violation for a specified proprietary header

@tkrop
Copy link
Member

tkrop commented Sep 6, 2022

👍

@vadeg
Copy link
Contributor

vadeg commented Oct 9, 2022

👍

@vadeg vadeg closed this Oct 9, 2022
@vadeg vadeg reopened this Oct 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 76.44% // Head: 76.41% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4dc9132) compared to base (2e5b8f7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1405      +/-   ##
============================================
- Coverage     76.44%   76.41%   -0.04%     
+ Complexity      722      721       -1     
============================================
  Files           170      170              
  Lines          2798     2798              
  Branches        489      489              
============================================
- Hits           2139     2138       -1     
  Misses          413      413              
- Partials        246      247       +1     
Impacted Files Coverage Δ
...do/zally/ruleset/zalando/ProprietaryHeadersRule.kt 72.41% <0.00%> (-3.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vadeg vadeg merged commit 145d2b7 into zalando:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Update Test
4 participants