Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

Support Private Repositories #392

Closed
mfellner opened this issue Jul 28, 2016 · 4 comments
Closed

Support Private Repositories #392

mfellner opened this issue Jul 28, 2016 · 4 comments

Comments

@mfellner
Copy link
Contributor

Allow users to add the repo scope in order to use Zappr with private repositories. This scope gives full access to private repositories thus we must not add it by default.

Dependencies

@prayerslayer
Copy link
Contributor

For Enterprise installations it would be already sufficient to just drop/change the visibility parameter from here?

@j0k3r
Copy link

j0k3r commented Aug 9, 2016

@prayerslayer it's all the case for non Entreprise install.

Switching the GITHUB_SCOPES isn't enough this line should also be switched to all instead of public.
Maybe this line can be switched to all for every one. Scope will limit private repo to show up.

@prayerslayer
Copy link
Contributor

Yes, true, we also need to change the scopes. However in Enterprise installations you provide the configuration yourself anyways, including scopes to request. For Github.com we really need to do #90 first.

I'd expect all to work too.

@mfellner
Copy link
Contributor Author

mfellner commented Sep 9, 2016

Closed with #406

@mfellner mfellner closed this as completed Sep 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants