This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Flexible permissions & private repo support #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayerslayer
changed the title
Less permissions & private repo support
Flexible permissions & private repo support
Aug 14, 2016
ADD COLUMN access_level ${dialect === 'postgres' ? 'zappr_data.enum_users_access_level' : 'TEXT'} NOT NULL DEFAULT 'minimal';`), | ||
queryInterface.addColumn({ | ||
tableName: 'checks', | ||
schema: 'zappr_data' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This essentially makes the configuration option DB_SCHEMA
obsolete.
; Conflicts: ; client/containers/RepositoryDetail.jsx
…missions ; Conflicts: ; config/system.yaml ; server/handler/CheckHandler.js ; server/model/Check.js ; server/server.js ; test/server/model.test.js
👍 |
1 similar comment
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
minimal
(the default) andextended
. They differ in the scopes needed. Currently the only difference ispublic_repo
in minimal level vsrepo
scope in extended level.zappr_access_level
is always set and equal to the user's choice. This is to avoid doing the auth flow twice all the time (because we only know the user and can load it from the database after the first auth flow, and might then need to do a second to have all necessary scopes).Todo
Further improvements (not necessarily in this PR)