Skip to content
This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

Track actions performance #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Track actions performance #4

wants to merge 2 commits into from

Conversation

zalmoxisus
Copy link
Owner

Similarly to timestamp property for each stored entry of actionsById, we're introducing perf property, so we'll be able to know not only when an action started, but also how much time it took to execute its reducer.

This should be rather useful for measuring the performance.

@gaearon, what do you think?

@gaearon
Copy link
Collaborator

gaearon commented May 18, 2016

Maybe timeSpentInReducer or duration?

@zalmoxisus
Copy link
Owner Author

duration is indeed better. I don't think it's necessary to clarify that it's about reducers. Similarly, timestamp is also when the reducer starts, not when the action creator is called.

@gaearon
Copy link
Collaborator

gaearon commented May 18, 2016

Fair enough. We just need to manage expectations because when people think of “how much time it took to process an action” they usually want to know how long components took to update, not just reducers.

@zalmoxisus
Copy link
Owner Author

It would be great to show perf not only for reducers, but it doesn't seem to be possible here.
Better to specify it in the docs, so I've updated the README, please amend it when you get time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants