refactor: avoid using unsafe code where possible #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Feb 28, 2023
sarah-quinones
force-pushed
the
safety-refactor
branch
2 times, most recently
from
596c663
to
9e917c5
Compare
IceTDrinker
reviewed
Mar 1, 2023
sarah-quinones
force-pushed
the
safety-refactor
branch
2 times, most recently
from
7ae71a7
to
0bc3404
Compare
IceTDrinker
approved these changes
Mar 3, 2023
sarah-quinones
force-pushed
the
safety-refactor
branch
from
0bc3404
to
bae43bb
Compare
|
superseded by #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is essentially a full rewrite of
concrete-fft.by depending on the bytemuck crate (which is a very lightweight and heavily tested dependency), and with the new
PodStackabstraction from dyn-stack (which we already depend on) to avoid dealing with uninitialized memory, we can avoid over 99% of the unsafe code usage inconcrete-fft.