Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compiler): Update security curves #873

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

BourgerieQuentin
Copy link
Member

workerB
security estimated using the MATZOV cost model in the lattice estimator
commit: 60808bdc17f99b78bd1bbcd621af04bc6f0e98bb
(see "Report on the Security of LWE: Improved Dual Lattice Attack", April 2022)

close zama-ai/concrete-internal#730

Copy link
Contributor

@rudy-6-4 rudy-6-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer other curves ?
This is going to break the optimizer CI.

Copy link
Contributor

@rudy-6-4 rudy-6-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concrete_security_curves::gaussian::security::supported_security_levels;
is not modified ?

@BourgerieQuentin
Copy link
Member Author

it was not updated so I just update the 128 one, as we use only that on compiler. But @bencrts works on updating the code and all curves we need.

@BourgerieQuentin
Copy link
Member Author

concrete_security_curves::gaussian::security::supported_security_levels; should use generated curves

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8a21fe6 Previous: 52736d4 Ratio
v0 PBS table generation 60820150 ns/iter (± 1076036) 60986750 ns/iter (± 3180220) 1.00
v0 PBS simulate dag table generation 40731906 ns/iter (± 447943) 40885868 ns/iter (± 2036630) 1.00
v0 WoP-PBS table generation 49825307 ns/iter (± 525042) 49846938 ns/iter (± 1239929) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@rudy-6-4 rudy-6-4 force-pushed the update-security-curves branch 2 times, most recently from f178da1 to 9ef7616 Compare June 18, 2024 16:25
@bencrts
Copy link
Member

bencrts commented Jun 20, 2024

The new scripts / curves are here:

https://github.com/zama-ai/parameter-curves

(see the README for the workflow). Currently, there isn't a Makefile etc. Let me know how you want me to proceed, I can either:

(1) just add the raw curve files
(2) add curves + scripts

@rudy-6-4
Copy link
Contributor

The new scripts / curves are here:

https://github.com/zama-ai/parameter-curves

(see the README for the workflow). Currently, there isn't a Makefile etc. Let me know how you want me to proceed, I can either:

(1) just add the raw curve files (2) add curves + scripts

I think (1) is ok for concrete now.
But having (2) + Makefile targets for setup and regen_curves would be better in long term.

@BourgerieQuentin BourgerieQuentin merged commit 040e152 into main Aug 22, 2024
27 of 28 checks passed
@BourgerieQuentin BourgerieQuentin deleted the update-security-curves branch August 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants