-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): pin actions to commits instead of version #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 25e8f95 | Previous: 9b0df72 | Ratio |
---|---|---|---|
v0 PBS table generation |
59816000 ns/iter (± 1166749 ) |
60114206 ns/iter (± 1531910 ) |
1.00 |
v0 PBS simulate dag table generation |
38945144 ns/iter (± 445046 ) |
38798212 ns/iter (± 1461911 ) |
1.00 |
v0 WoP-PBS table generation |
67639866 ns/iter (± 573482 ) |
68020792 ns/iter (± 599240 ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
7aa6f86
to
922d4cb
Compare
Look like there are some CI error due to this change, can you take a look? |
922d4cb
to
e70635a
Compare
seems there is an issue of GLIBC for node in the docker image used, something to upgrade after in a separate PR, I reverted webfactory/ssh-agent to the version used |
e70635a
to
6956dd0
Compare
seems ok now, I need to wait for optimizer and mac CI to be fixed to rebase cc @BourgerieQuentin |
by the way I think we don't actually use webfactory/ssh-agent it was at the time we have private repository... |
I think there is a cleanup to do, same for the GPU docker image that seems to force actions to be in old versions |
6956dd0
to
3846d83
Compare
3846d83
to
25e8f95
Compare
No description provided.