Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pin actions to commits instead of version #893

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

aquint-zama
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 25e8f95 Previous: 9b0df72 Ratio
v0 PBS table generation 59816000 ns/iter (± 1166749) 60114206 ns/iter (± 1531910) 1.00
v0 PBS simulate dag table generation 38945144 ns/iter (± 445046) 38798212 ns/iter (± 1461911) 1.00
v0 WoP-PBS table generation 67639866 ns/iter (± 573482) 68020792 ns/iter (± 599240) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@BourgerieQuentin
Copy link
Member

Look like there are some CI error due to this change, can you take a look?

@aquint-zama
Copy link
Contributor Author

Look like there are some CI error due to this change, can you take a look?

seems there is an issue of GLIBC for node in the docker image used, something to upgrade after in a separate PR, I reverted webfactory/ssh-agent to the version used v0.7.0

@aquint-zama
Copy link
Contributor Author

seems ok now, I need to wait for optimizer and mac CI to be fixed to rebase cc @BourgerieQuentin

@BourgerieQuentin
Copy link
Member

by the way I think we don't actually use webfactory/ssh-agent it was at the time we have private repository...

@aquint-zama
Copy link
Contributor Author

by the way I think we don't actually use webfactory/ssh-agent it was at the time we have private repository...

I think there is a cleanup to do, same for the GPU docker image that seems to force actions to be in old versions

@BourgerieQuentin BourgerieQuentin merged commit 485cd86 into main Jun 27, 2024
36 of 38 checks passed
@BourgerieQuentin BourgerieQuentin deleted the fix/actions-versions branch June 27, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants