Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix small typo in the documentation about re-encryption #453

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

fd0r
Copy link
Contributor

@fd0r fd0r commented Jul 31, 2024

c.f.

const balanceHandleAlice = await this.erc20.balanceOf(this.signers.alice);
const { publicKey, privateKey } = this.instances.alice.generateKeypair();
const eip712 = this.instances.alice.createEIP712(publicKey, this.contractAddress);
const signature = await this.signers.alice.signTypedData(
eip712.domain,
{ Reencrypt: eip712.types.Reencrypt },
eip712.message,
);
const balanceAlice = await this.instances.alice.reencrypt(
balanceHandleAlice,
privateKey,
publicKey,
signature.replace('0x', ''),
this.contractAddress,
this.signers.alice.address,
);

Following a discussion at the office with @leventdem we noticed a small typo in the documentation. Indeed even in the case of re-encryption the gateway receives the handle and not the cipher-text.

@fd0r fd0r force-pushed the fd0r/chore/small_fix_handle_doc_0_5_x branch 2 times, most recently from e16719e to c0effc3 Compare July 31, 2024 11:26
Following a discussion at the office with @leventdem we noticed a small
typo in the documentation. Indeed even in the case of re-encryption the
gateway receives the handle and not the cipher-text.

https://github.com/zama-ai/fhevm/blob/
914699f/test/encryptedERC20/EncryptedERC20.ts#L76-L91
@fd0r fd0r force-pushed the fd0r/chore/small_fix_handle_doc_0_5_x branch from c0effc3 to 9219dd9 Compare July 31, 2024 11:26
@fd0r
Copy link
Contributor Author

fd0r commented Jul 31, 2024

I had to break down the url in the commit message because of the line-length limit in commitlint.

(conventional-changelog/commitlint#2112)

@fd0r fd0r merged commit 55767af into release/0.5.x Aug 1, 2024
3 checks passed
@fd0r fd0r deleted the fd0r/chore/small_fix_handle_doc_0_5_x branch August 1, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants