Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gpu): refactor sample extract and modulus switch to match CPU's version #1414

Merged
merged 1 commit into from
Jul 25, 2024
Merged

refactor(gpu): refactor sample extract and modulus switch to match CPU's version #1414

merged 1 commit into from
Jul 25, 2024

Conversation

pdroalves
Copy link
Contributor

…

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/668

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Jul 24, 2024
agnesLeroy
agnesLeroy approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @pdroalves, this will actually speed up a bit the PBS. 🙂

backends/tfhe-cuda-backend/cuda/src/polynomial/functions.cuh Show resolved Hide resolved
@zama-bot zama-bot removed the approved label Jul 24, 2024
@zama-bot zama-bot removed the approved label Jul 24, 2024
@pdroalves pdroalves added 4090_test Launch test on our CI 4090 desktop 4090_bench Launch integer bench on our CI 4090 desktop labels Jul 24, 2024
@github-actions github-actions bot removed 4090_bench Launch integer bench on our CI 4090 desktop 4090_test Launch test on our CI 4090 desktop labels Jul 24, 2024
@agnesLeroy
Copy link
Contributor

@pdroalves the 64-bit benchmark results on H100 are the same for all operations except mul/shift/rotate, which are better:
Screenshot from 2024-07-25 11-38-20

@agnesLeroy agnesLeroy merged commit 19dc0f0 into main Jul 25, 2024
154 of 164 checks passed
@agnesLeroy agnesLeroy deleted the pa/refactor/se_ms branch July 25, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

@bbarbakadze bbarbakadze Awaiting requested review from bbarbakadze

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdroalves @agnesLeroy @zama-bot