Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): update LE commit #1442

Closed
wants to merge 1 commit into from
Closed

chore(CI): update LE commit #1442

wants to merge 1 commit into from

Conversation

bencrts
Copy link
Member

@bencrts bencrts commented Aug 1, 2024

WIP

@cla-bot cla-bot bot added the cla-signed label Aug 1, 2024
@bencrts bencrts force-pushed the bc/ci/estimator branch 2 times, most recently from 101dea5 to 98b9afc Compare August 1, 2024 11:19
@bencrts bencrts force-pushed the bc/ci/estimator branch 2 times, most recently from 554fc99 to 68c8235 Compare August 12, 2024 18:16
@bencrts
Copy link
Member Author

bencrts commented Aug 12, 2024

@IceTDrinker I think this is ready for merging -- the commit ID has been updated and the CI check passes in 38min.

@bencrts bencrts force-pushed the bc/ci/estimator branch 2 times, most recently from 72de6a8 to d9cc0ca Compare August 12, 2024 18:17
@IceTDrinker
Copy link
Member

@IceTDrinker I think this is ready for merging -- the commit ID has been updated and the CI check passes in 38min.

Thanks will check that tomorrow !

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you need more details as to what I have in mind don't hesitate to ping :)

@@ -24,7 +24,6 @@ jobs:
with:
repository: malb/lattice-estimator
path: lattice_estimator
ref: '53508253629d3b5d31a2ad110e85dc69391ccb95'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we pin the more recent reference ? it is to avoid random breakage in the CI and means we have to dedicate some time from time to time to update the commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll add the current commit back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back on L27

Comment on lines -40 to +48
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 0 "boolean_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 1 "boolean_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 2 "boolean_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 0 "shortint_classic_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 1 "shortint_classic_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 2 "shortint_classic_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 0 "shortint_multi_bit_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 1 "shortint_multi_bit_parameters_lattice_estimator"
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 2 "shortint_multi_bit_parameters_lattice_estimator"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is likely unnecessary by auto partitioning in the sage script ?

also if this is an issue we can just change the runs-on of the job to e.g. large_ubuntu_16 see line 17, this way the change to the sage script may not be required anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that releasing memory from a single run of the script seems to be a bit problematic -- the CI machine runs out of RAM and crashes. Splitting up the task in this way with some command line args is a bit of an easy way around it

"""


# This file was *autogenerated* from the file ci/lattice_estimator.sage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

careful you committed an auto generated file

@bencrts bencrts marked this pull request as draft August 13, 2024 10:33
@bencrts bencrts closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants