-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): update LE commit #1442
Conversation
101dea5
to
98b9afc
Compare
554fc99
to
68c8235
Compare
@IceTDrinker I think this is ready for merging -- the commit ID has been updated and the CI check passes in 38min. |
72de6a8
to
d9cc0ca
Compare
Thanks will check that tomorrow ! |
d9cc0ca
to
db14687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you need more details as to what I have in mind don't hesitate to ping :)
@@ -24,7 +24,6 @@ jobs: | |||
with: | |||
repository: malb/lattice-estimator | |||
path: lattice_estimator | |||
ref: '53508253629d3b5d31a2ad110e85dc69391ccb95' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we pin the more recent reference ? it is to avoid random breakage in the CI and means we have to dedicate some time from time to time to update the commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll add the current commit back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back on L27
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 0 "boolean_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 1 "boolean_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 2 "boolean_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 0 "shortint_classic_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 1 "shortint_classic_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 2 "shortint_classic_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 0 "shortint_multi_bit_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 1 "shortint_multi_bit_parameters_lattice_estimator" | ||
PYTHONPATH=lattice_estimator sage ci/lattice_estimator.sage 2 "shortint_multi_bit_parameters_lattice_estimator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is likely unnecessary by auto partitioning in the sage script ?
also if this is an issue we can just change the runs-on of the job to e.g. large_ubuntu_16 see line 17, this way the change to the sage script may not be required anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that releasing memory from a single run of the script seems to be a bit problematic -- the CI machine runs out of RAM and crashes. Splitting up the task in this way with some command line args is a bit of an easy way around it
db14687
to
3c47a32
Compare
ci/lattice_estimator.sage.py
Outdated
""" | ||
|
||
|
||
# This file was *autogenerated* from the file ci/lattice_estimator.sage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
careful you committed an auto generated file
f852d22
to
3c47a32
Compare
WIP