Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Al/fix multiplication scratch headers #1452

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Al/fix multiplication scratch headers #1452

merged 1 commit into from
Aug 2, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
pdroalves
pdroalves approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should have checked for missing max_shared_memory yesterday. Sorry.

@agnesLeroy
Copy link
Contributor Author

We probably should have checked for missing max_shared_memory yesterday. Sorry.

I checked for them actually, but missed this one somehow sorry...

@zama-bot zama-bot removed the approved label Aug 2, 2024
@agnesLeroy agnesLeroy merged commit a9bb6ea into main Aug 2, 2024
67 of 68 checks passed
@agnesLeroy agnesLeroy deleted the al/debug-bench branch August 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdroalves pdroalves pdroalves approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @pdroalves @zama-bot