Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): switch to slab action for pull-request workflows #839

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jan 31, 2024

First batch of changes for workflows related to pull requests.

@soonum soonum added the ci label Jan 31, 2024
@soonum soonum self-assigned this Jan 31, 2024
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2024
@IceTDrinker
Copy link
Member

I don't see the GPU tests starting ?

@soonum soonum force-pushed the dt/ci/convert_to_slab_action branch from 2502389 to 70cecec Compare January 31, 2024 11:55
@IceTDrinker
Copy link
Member

can you run actionlint locally @soonum so that we don't miss small mistakes ?

@soonum soonum force-pushed the dt/ci/convert_to_slab_action branch from 70cecec to ca6fa93 Compare January 31, 2024 14:15
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what this thing can do 👀

@IceTDrinker
Copy link
Member

CSPRNG does not seem to start

@soonum soonum force-pushed the dt/ci/convert_to_slab_action branch from ffa17cc to 84a9fdf Compare February 1, 2024 08:43
@soonum soonum force-pushed the dt/ci/convert_to_slab_action branch from 84a9fdf to a913359 Compare February 1, 2024 09:32
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah s... here we go again 😉

@soonum soonum force-pushed the dt/ci/convert_to_slab_action branch from a913359 to 1b8bc98 Compare February 1, 2024 09:53
@soonum soonum force-pushed the dt/ci/convert_to_slab_action branch from 1b8bc98 to e7f9cb5 Compare February 1, 2024 14:15
@github-actions github-actions bot removed the approved label Feb 1, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more approve !

@soonum soonum merged commit 45befca into main Feb 2, 2024
31 checks passed
@soonum soonum deleted the dt/ci/convert_to_slab_action branch February 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants